]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ALSA: hda: tas2781-spi: Fix bogus error handling in tas2781_hda_spi_probe()
authorTakashi Iwai <tiwai@suse.de>
Wed, 22 Jan 2025 08:47:55 +0000 (09:47 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 22 Jan 2025 11:17:04 +0000 (12:17 +0100)
commit6aa96f780204bfdac225eb4c8f51f86c38cc1a26
tree248497bcf794a5eac6bc6bf6dc82bd0c7eabfe52
parent807563cdc85dac2d151d7d93676d1551d067c72b
ALSA: hda: tas2781-spi: Fix bogus error handling in tas2781_hda_spi_probe()

The error handling in tas2781_hda_spi_probe() has quite a few
problems, as reported by Dan Carpenter.  The code jumps to err label
and calls tas2781_hda_remove(), but this call would rather crash.
In some places, no error code is set properly, and the runtime PM
setup is doubly done.

This patch tries to address those bogus error handling.  Basically we
can return immediately at each error before adding the component.
Also, the error code should be set properly for the unmatched SPI
device name.  And finally, component_add() should be added before
enabling the runtime PM.

Fixes: bb5f86ea50ff ("ALSA: hda/tas2781: Add tas2781 hda SPI driver")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/ae5fcd48-58ac-49a8-a434-5f779bad0fb7@stanley.mountain
Link: https://patch.msgid.link/20250122084756.23876-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/tas2781_hda_spi.c