]> www.infradead.org Git - users/jedix/linux-maple.git/commit
PCI/AER: Consolidate Error Source ID logging in aer_isr_one_error_type()
authorBjorn Helgaas <bhelgaas@google.com>
Thu, 22 May 2025 23:21:10 +0000 (18:21 -0500)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 23 May 2025 16:00:14 +0000 (11:00 -0500)
commit6a1eda745967a1e84f6e4cae14c118c97319891e
treee1ba9ca05c62ab1ce0c226cc3ddafe67f3f05279
parent6fc4dae74afcf29ef82afbaaa9b082893871eda4
PCI/AER: Consolidate Error Source ID logging in aer_isr_one_error_type()

Previously we decoded the AER Error Source ID in aer_isr_one_error_type(),
then again in find_source_device() if we didn't find any devices with
errors logged in their AER Capabilities.

Consolidate this so we only decode and log the Error Source ID once in
aer_isr_one_error_type().  Add a "found" parameter so we can add a note
when we didn't find any downstream devices with errors logged in their AER
Capability.

This changes the dmesg logging when we found no devices with errors logged:

  - pci 0000:00:01.0: AER: Correctable error message received from 0000:02:00.0
  - pci 0000:00:01.0: AER: found no error details for 0000:02:00.0
  + pci 0000:00:01.0: AER: Correctable error message received from 0000:02:00.0 (no details found)

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://patch.msgid.link/20250522232339.1525671-5-helgaas@kernel.org
drivers/pci/pcie/aer.c