]> www.infradead.org Git - users/jedix/linux-maple.git/commit
xfrm: policy: fix null dereference
authorFlorian Westphal <fw@strlen.de>
Fri, 30 Aug 2024 14:39:10 +0000 (16:39 +0200)
committerSteffen Klassert <steffen.klassert@secunet.com>
Mon, 9 Sep 2024 13:30:05 +0000 (15:30 +0200)
commit6a13f5afd39d17320316dbb8dd533fe7c6a613e6
tree81f2899111af9560bd5c82f628bda7caf6e38538
parent69716a3babe1165a9ab1b3770b55d303d5bb5fa3
xfrm: policy: fix null dereference

Julian Wiedmann says:
> +     if (!xfrm_pol_hold_rcu(ret))

Coverity spotted that ^^^ needs a s/ret/pol fix-up:

> CID 1599386:  Null pointer dereferences  (FORWARD_NULL)
> Passing null pointer "ret" to "xfrm_pol_hold_rcu", which dereferences it.

Ditch the bogus 'ret' variable.

Fixes: 563d5ca93e88 ("xfrm: switch migrate to xfrm_policy_lookup_bytype")
Reported-by: Julian Wiedmann <jwiedmann.dev@gmail.com>
Closes: https://lore.kernel.org/netdev/06dc2499-c095-4bd4-aee3-a1d0e3ec87c4@gmail.com/
Signed-off-by: Florian Westphal <fw@strlen.de>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/xfrm/xfrm_policy.c