]> www.infradead.org Git - users/hch/uuid.git/commit
can: mcp251x: Use DT-supplied interrupt flags
authorPhil Elwell <phil@raspberrypi.org>
Tue, 14 Nov 2017 11:03:22 +0000 (11:03 +0000)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Tue, 20 Aug 2019 11:41:26 +0000 (13:41 +0200)
commit6a07c2305ab200844f250f4dba47ed60d0640505
tree416ba6b634d3fc4d1740eff4417add0851720118
parent3964576307edf408435949633b1f600262d70bb6
can: mcp251x: Use DT-supplied interrupt flags

The MCP2515 datasheet clearly describes a level-triggered interrupt pin.
Therefore the receiving interrupt controller must also be configured for
level-triggered operation otherwise there is a danger of a missed
interrupt condition blocking all subsequent interrupts. The ONESHOT
flag ensures that the interrupt is masked until the threaded interrupt
handler exits.

Rather than change the flags globally (they must have worked for at
least one user), keep the old behavior for for non DT devices. DT based
devices specify the flags in their corresonding DT node.

See: https://github.com/raspberrypi/linux/issues/2175
     https://github.com/raspberrypi/linux/issues/2263

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Tested-by: Sean Nyekjaer <sean@geanix.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/spi/mcp251x.c