]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/amdgpu: optimize queue reset and stop logic for sdma_v5_2
authorJesse.zhang@amd.com <Jesse.zhang@amd.com>
Wed, 16 Apr 2025 06:13:30 +0000 (14:13 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 21 Apr 2025 14:57:07 +0000 (10:57 -0400)
commit6a07ac702f022dc85b186e7d2bec6216a0c260b0
tree15bbf295e7b9f423e24fdeb146ec392bd6131939
parent574f4b5562cc11da7beb8c14b51a846da8263f89
drm/amdgpu: optimize queue reset and stop logic for sdma_v5_2

This patch refactors the SDMA v5.2 queue reset and stop logic to improve
code readability, maintainability, and performance. The key changes include:

1. **Generalized `sdma_v5_2_gfx_stop` Function**:
   - Added an `inst_mask` parameter to allow stopping specific SDMA instances
     instead of all instances. This is useful for resetting individual queues.

2. **Simplified `sdma_v5_2_reset_queue` Function**:
   - Removed redundant loops and checks by directly using the `ring->me` field
     to identify the SDMA instance.
   - Reused the `sdma_v5_2_gfx_stop` function to stop the queue, reducing code
     duplication.

v1: The general coding style is to declare variables like "i" or "r" last. E.g. longest lines first and short lasts. (Chritian)

Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c