]> www.infradead.org Git - users/jedix/linux-maple.git/commit
media: venus: hfi: add check to handle incorrect queue size
authorVikash Garodia <quic_vgarodia@quicinc.com>
Thu, 20 Feb 2025 17:20:10 +0000 (22:50 +0530)
committerHans Verkuil <hverkuil@xs4all.nl>
Mon, 3 Mar 2025 17:21:55 +0000 (18:21 +0100)
commit69baf245b23e20efda0079238b27fc63ecf13de1
tree79ad4d24b7468967fd20cdae58086ee4c8246c09
parent9edaaa8e3e15aab1ca413ab50556de1975bcb329
media: venus: hfi: add check to handle incorrect queue size

qsize represents size of shared queued between driver and video
firmware. Firmware can modify this value to an invalid large value. In
such situation, empty_space will be bigger than the space actually
available. Since new_wr_idx is not checked, so the following code will
result in an OOB write.
...
qsize = qhdr->q_size

if (wr_idx >= rd_idx)
 empty_space = qsize - (wr_idx - rd_idx)
....
if (new_wr_idx < qsize) {
 memcpy(wr_ptr, packet, dwords << 2) --> OOB write

Add check to ensure qsize is within the allocated size while
reading and writing packets into the queue.

Cc: stable@vger.kernel.org
Fixes: d96d3f30c0f2 ("[media] media: venus: hfi: add Venus HFI files")
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/qcom/venus/hfi_venus.c