]> www.infradead.org Git - users/dwmw2/linux.git/commit
KVM: x86: work around leak of uninitialized stack contents
authorFuqian Huang <huangfq.daxian@gmail.com>
Thu, 12 Sep 2019 04:18:17 +0000 (12:18 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 Sep 2019 07:08:04 +0000 (09:08 +0200)
commit69b416ef9c05eeb438f16eee392f1b24e023aa9c
tree90e388a7b69ac467365ce13aac4fdf6f21f61b18
parentfd1b7efe8e04ef259e7beb2f68af8d4f7a7e9d8e
KVM: x86: work around leak of uninitialized stack contents

commit 541ab2aeb28251bf7135c7961f3a6080eebcc705 upstream.

Emulation of VMPTRST can incorrectly inject a page fault
when passed an operand that points to an MMIO address.
The page fault will use uninitialized kernel stack memory
as the CR2 and error code.

The right behavior would be to abort the VM with a KVM_EXIT_INTERNAL_ERROR
exit to userspace; however, it is not an easy fix, so for now just ensure
that the error code and CR2 are zero.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Cc: stable@vger.kernel.org
[add comment]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/x86/kvm/x86.c