]> www.infradead.org Git - users/jedix/linux-maple.git/commit
irqchip/apple-aic: Only handle PMC interrupt as FIQ when configured so
authorNick Chan <towinchenmi@gmail.com>
Sat, 18 Jan 2025 16:31:42 +0000 (00:31 +0800)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 27 Jan 2025 17:39:15 +0000 (18:39 +0100)
commit698244bbb3bfd32ddf9a0b70a12b1c7d69056497
tree3d6d943b0e36f68248931295883ce0721078d602
parent987f379b54091cc1b1db986bde71cee1081350b3
irqchip/apple-aic: Only handle PMC interrupt as FIQ when configured so

The CPU PMU in Apple SoCs can be configured to fire its interrupt in one of
several ways, and since Apple A11 one of the methods is FIQ, but the check
of the configuration register fails to test explicitely for FIQ mode. It
tests whether the IMODE bitfield is zero or not and the PMCRO_IACT bit is
set. That results in false positives when the IMODE bitfield is not zero,
but does not have the mode PMCR0_IMODE_FIQ.

Only handle the PMC interrupt as a FIQ when the CPU PMU has been configured
to fire FIQs, i.e. the IMODE bitfield value is PMCR0_IMODE_FIQ and
PMCR0_IACT is set.

Fixes: c7708816c944 ("irqchip/apple-aic: Wire PMU interrupts")
Signed-off-by: Nick Chan <towinchenmi@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/all/20250118163554.16733-1-towinchenmi@gmail.com
drivers/irqchip/irq-apple-aic.c