]> www.infradead.org Git - users/dwmw2/linux.git/commit
drm/xe: Nuke xe's copy of intel_fbdev_fb.h
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 6 May 2024 18:33:31 +0000 (21:33 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 9 May 2024 21:01:54 +0000 (00:01 +0300)
commit6907d4fa5ecac7b08fb5ee5536e48b0a3895be31
treee34a5566ce25cde6efc4dc6043d719c36f45980b
parent0097ecd06d9dcf671da4bc643d215a4696f1c130
drm/xe: Nuke xe's copy of intel_fbdev_fb.h

For some reason xe and i915 each have an identical (fortunately)
copy of intel_fbdev_fb.h. The xe copy actually only gets included
by xe's intel_fbdev_fb.c, and the i915 copy by everyone else,
include intel_fbdev.c which is the actual caller of the
functions declared in the header.

This means the xe and i915 headers are free to define/declare
completely incompatible things and the build would still succeed
as long as the symbol names match.

That is not a good thing, so let's nuke xe's copy of the header
so that everyone will use the same header, and be forced to
agree on the same API/ABI.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240506183331.7720-1-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/display/intel_fbdev_fb.h [deleted file]