]> www.infradead.org Git - users/jedix/linux-maple.git/commit
e1000: fix lockdep splat in shutdown handler
authorJesse Brandeburg <jesse.brandeburg@intel.com>
Wed, 4 Jan 2012 20:23:33 +0000 (20:23 +0000)
committerJoe Jin <joe.jin@oracle.com>
Thu, 17 May 2012 03:19:53 +0000 (11:19 +0800)
commit688a4a4b0cf637c158353a9c59eb6a8573e37eff
tree2a5cded7ca1d9624ebb424d2c8e7ea562a891b15
parentec82a370e92a8af89300c5e3791d23c56ca666f4
e1000: fix lockdep splat in shutdown handler

As reported by Steven Rostedt, e1000 has a lockdep splat added
during the recent merge window.  The issue is that
cancel_delayed_work is called while holding our private mutex.

There is no reason that I can see to hold the mutex during pci
shutdown, it was more just paranoia that I put the mutex_lock
around the call to e1000_down.

In a quick survey lots of drivers handle locking differently when
being called by the pci layer.  The assumption here is that we
don't need the mutexes' protection in this function because
the driver could not be unloaded while in the shutdown handler
which is only called at reboot or poweroff.

Reported-by: Steven Rostedt <rostedt@goodmis.org>
(cherry picked from commit 3a3847e007aae732d64d8fd1374126393e9879a3)
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Steven Rostedt <rostedt@goodmis.org>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Joe Jin <joe.jin@oracle.com>
drivers/net/e1000/e1000_main.c