]> www.infradead.org Git - users/dwmw2/linux.git/commit
ice: Fix inability to set channels when down
authorJesse Brandeburg <jesse.brandeburg@intel.com>
Sat, 16 May 2020 00:55:00 +0000 (17:55 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 22 Jun 2020 07:32:52 +0000 (09:32 +0200)
commit686b7129f119d11b00c378d6f0b7e67474d899a1
tree324f2ac7210efb2c598116eda9a5fded5c569b38
parentf172e03d279bf93fe71b7b514a5b20eb6c6448ae
ice: Fix inability to set channels when down

[ Upstream commit 765dd7a1827c687b782e6ab3dd6daf4d13a4780f ]

Currently the driver prevents a user from doing
modprobe ice
ethtool -L eth0 combined 5
ip link set eth0 up

The ethtool command fails, because the driver is checking to see if the
interface is down before allowing the get_channels to proceed (even for
a set_channels).

Remove this check and allow the user to configure the interface
before bringing it up, which is a much better usability case.

Fixes: 87324e747fde ("ice: Implement ethtool ops for channels")
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/intel/ice/ice_ethtool.c