]> www.infradead.org Git - users/jedix/linux-maple.git/commit
bcachefs: Remove incorrect __counted_by annotation
authorAlan Huang <mmpgouride@gmail.com>
Thu, 1 May 2025 20:01:31 +0000 (04:01 +0800)
committerKent Overstreet <kent.overstreet@linux.dev>
Thu, 1 May 2025 20:38:58 +0000 (16:38 -0400)
commit6846100b00d97d3d6f05766ae86a0d821d849e78
treeafa76c12f415721ac1ba9d9562f48c7c1df8de20
parent28580052e634fe8fa327e6f25c35590374be754b
bcachefs: Remove incorrect __counted_by annotation

This actually reverts 86e92eeeb237 ("bcachefs: Annotate struct bch_xattr
with __counted_by()").

After the x_name, there is a value. According to the disscussion[1],
__counted_by assumes that the flexible array member contains exactly
the amount of elements that are specified. Now there are users came across
a false positive detection of an out of bounds write caused by
the __counted_by here[2], so revert that.

[1] https://lore.kernel.org/lkml/Zv8VDKWN1GzLRT-_@archlinux/T/#m0ce9541c5070146320efd4f928cc1ff8de69e9b2
[2] https://privatebin.net/?a0d4e97d590d71e1#9bLmp2Kb5NU6X6cZEucchDcu88HzUQwHUah8okKPReEt

Signed-off-by: Alan Huang <mmpgouride@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/xattr_format.h