]> www.infradead.org Git - users/jedix/linux-maple.git/commit
btrfs: exit after state insertion failure at set_extent_bit()
authorFilipe Manana <fdmanana@suse.com>
Wed, 16 Apr 2025 14:56:53 +0000 (15:56 +0100)
committerDavid Sterba <dsterba@suse.com>
Thu, 15 May 2025 12:30:51 +0000 (14:30 +0200)
commit67f10a10187b17ac62abddf66d16cec9d0f89a7c
tree59c24fa60c3c73dc477149dc11cf7e477d70615f
parent0edc1a5c543c024934e7418aa76d2e8309e0303f
btrfs: exit after state insertion failure at set_extent_bit()

If insert_state() state failed it returns an error pointer and we call
extent_io_tree_panic() which will trigger a BUG() call. However if
CONFIG_BUG is disabled, which is an uncommon and exotic scenario, then
we fallthrough and call cache_state() which will dereference the error
pointer, resulting in an invalid memory access.

So jump to the 'out' label after calling extent_io_tree_panic(), it also
makes the code more clear besides dealing with the exotic scenario where
CONFIG_BUG is disabled.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/extent-io-tree.c