]> www.infradead.org Git - users/jedix/linux-maple.git/commit
rtc: hctosys: Add missing range error reporting
authorMaciej W. Rozycki <macro@linux-mips.org>
Mon, 5 Nov 2018 03:48:25 +0000 (03:48 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 Nov 2018 08:24:14 +0000 (09:24 +0100)
commit677f423c995d27bfafd34a7b86773830db6ac09f
tree1df06ec4ddbf3793f7b2af537b71e965cfbdada4
parent6d1c38aa47d432f425c5829261eaa8e624274a4f
rtc: hctosys: Add missing range error reporting

commit 7ce9a992ffde8ce93d5ae5767362a5c7389ae895 upstream.

Fix an issue with the 32-bit range error path in `rtc_hctosys' where no
error code is set and consequently the successful preceding call result
from `rtc_read_time' is propagated to `rtc_hctosys_ret'.  This in turn
makes any subsequent call to `hctosys_show' incorrectly report in sysfs
that the system time has been set from this RTC while it has not.

Set the error to ERANGE then if we can't express the result due to an
overflow.

Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
Fixes: b3a5ac42ab18 ("rtc: hctosys: Ensure system time doesn't overflow time_t")
Cc: stable@vger.kernel.org # 4.17+
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/rtc/hctosys.c