]> www.infradead.org Git - users/jedix/linux-maple.git/commit
platform/x86: int3472: Fix skl_int3472_handle_gpio_resources() return value
authorHans de Goede <hdegoede@redhat.com>
Mon, 9 Dec 2024 22:05:21 +0000 (23:05 +0100)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 10 Dec 2024 13:41:25 +0000 (15:41 +0200)
commit6718d42b6eb28228a554db6c8973693ad5320006
treeac92df5c9db2419d8b86b8ff89c8677b1b6c6853
parent1dd0cb9cabf37fbe20f0a66e4c3972cb21240aed
platform/x86: int3472: Fix skl_int3472_handle_gpio_resources() return value

The INT3472 code never wants a copy of the ACPI resource to be added
to the list-head passed to acpi_dev_get_resources().

Make skl_int3472_handle_gpio_resources() always return -errno or 1.

Also update the inaccurate comment about the return value.
skl_int3472_handle_gpio_resources() was already returning 1 in the case
of not a GPIO resource or invalid _DSM return and not -EINVAL / -ENODEV
as the comment claimed.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20241209220522.25288-3-hdegoede@redhat.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/intel/int3472/discrete.c