]> www.infradead.org Git - users/dwmw2/linux.git/commit
HID: mcp2221: prevent a buffer overflow in mcp_smbus_write()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Mon, 20 Jun 2022 16:28:24 +0000 (09:28 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 21 Aug 2022 13:16:01 +0000 (15:16 +0200)
commit66c8e816f2f2ca4a61b406503bd10bad1b35f72f
treea2ca98262c14e3c3ab74034b49b17abc191eb73c
parent26975d8ea96b478897f8cb91a9bc2395d7f3393c
HID: mcp2221: prevent a buffer overflow in mcp_smbus_write()

[ Upstream commit 62ac2473553a00229e67bdf3cb023b62cf7f5a9a ]

Smatch Warning:
drivers/hid/hid-mcp2221.c:388 mcp_smbus_write() error: __memcpy()
'&mcp->txbuf[5]' too small (59 vs 255)
drivers/hid/hid-mcp2221.c:388 mcp_smbus_write() error: __memcpy() 'buf'
too small (34 vs 255)

The 'len' variable can take a value between 0-255 as it can come from
data->block[0] and it is user data. So add an bound check to prevent a
buffer overflow in memcpy().

Fixes: 67a95c21463d ("HID: mcp2221: add usb to i2c-smbus host bridge")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hid/hid-mcp2221.c