]> www.infradead.org Git - users/dwmw2/linux.git/commit
iio: adc: xilinx-ams: Fix single channel switching sequence
authorRobert Hancock <robert.hancock@calian.com>
Thu, 27 Jan 2022 17:34:50 +0000 (11:34 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 11:57:15 +0000 (13:57 +0200)
commit66556ba523964ca6c93d35a6b93a756861045a98
tree1194765bcd4d17e83a2c4f85b2f6070649839f52
parent49035aadf9e62a179552c1c4af6787f837ac4924
iio: adc: xilinx-ams: Fix single channel switching sequence

commit 0bf126163c3e7e6d722622073046aed567a5551e upstream.

Some of the AMS channels need to be read by switching into single-channel
mode from the normal polling sequence. There was a logic issue in this
switching code that could cause the first read of these channels to read
back as zero.

It appears that the sequencer should be set back to default mode before
changing the channel selection, and the channel should be set before
switching the sequencer back into single-channel mode.

Also, write 1 to the EOC bit in the status register to clear it before
waiting for it to become set, so that we actually wait for a new
conversion to complete, and don't proceed based on a previous conversion
completing.

Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver")
Signed-off-by: Robert Hancock <robert.hancock@calian.com>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Link: https://lore.kernel.org/r/20220127173450.3684318-5-robert.hancock@calian.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/adc/xilinx-ams.c