]> www.infradead.org Git - users/jedix/linux-maple.git/commit
selftests/net: Print TCP flags in more common format
authorDmitry Safonov <0x7f454c46@gmail.com>
Wed, 19 Mar 2025 03:13:34 +0000 (03:13 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 25 Mar 2025 13:10:29 +0000 (06:10 -0700)
commit65ffdf31be68aaa6b2480112e5f65b6e747a3724
treeb340b0ae928137aec3bc5dd1f954eb135dddbdbf
parent3e25c1a7c0566128557c3a1cfc1eea6f943bc137
selftests/net: Print TCP flags in more common format

Before:
># 13145[lib/ftrace-tcp.c:427] trace event filter tcp_ao_key_not_found [2001:db8:1::1:-1 => 2001:db8:254::1:7010, L3index 0, flags: !FS!R!P!., keyid: 100, rnext: 100, maclen: -1, sne: -1] = 1

After:
># 13487[lib/ftrace-tcp.c:427] trace event filter tcp_ao_key_not_found [2001:db8:1::1:-1 => 2001:db8:254::1:7010, L3index 0, flags: S, keyid: 100, rnext: 100, maclen: -1, sne: -1] = 1

For the history, I think the initial format was to emphasize the absence
of flags as well as their presence (!R meant no RST flag). But looking
again, it's just unreadable and hard to understand.
Make it the standard/expected one.

Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com>
Link: https://patch.msgid.link/20250319-tcp-ao-selftests-polling-v2-1-da48040153d1@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c