]> www.infradead.org Git - users/jedix/linux-maple.git/commit
be2net: Avoid redundant addition of mac address in HW
authorSuresh Reddy <Suresh.Reddy@broadcom.com>
Wed, 7 Sep 2016 14:27:52 +0000 (19:57 +0530)
committerChuck Anderson <chuck.anderson@oracle.com>
Tue, 11 Jul 2017 07:10:01 +0000 (00:10 -0700)
commit659ccdffbfb6f24e05e6f08761e6ef09bea63781
tree4741ff188021a101fd93ad95d7bfd2d62ae4ba8c
parent51e6076a0257645b23e62e31eca13716343467da
be2net: Avoid redundant addition of mac address in HW

If a mac address is added to the uc_list and later the same mac address
is added via ndo_set_mac_address() or vice versa, the driver does not
detect this condition and tries to add it again. This results in a mac
address collision error when the FW rejects it.

Fix this by checking if the given mac address is present in uc_list while
setting the device mac address and vice versa. Similarly skip deletion if
the address is still in use in the other form.

Orabug: 26403655

Signed-off-by: Suresh Reddy <Suresh.Reddy@broadcom.com>
Signed-off-by: Sathya Perla <sathya.perla@broadcom.com>
Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Suresh Reddy <suresh.reddy@broadcom.com>
Signed-off-by: Kirtikar Kashyap <kirtikar.kashyap@oracle.com>
Reviewed-by: Reviewed-by: Jack Vogel <jack.vogel@oracle.com>
drivers/net/ethernet/emulex/benet/be_main.c