]> www.infradead.org Git - users/sagi/libnvme.git/commit
ioctl: Rearrange members in nvme_get_log_args
authorDaniel Wagner <dwagner@suse.de>
Thu, 13 Jan 2022 13:43:31 +0000 (14:43 +0100)
committerDaniel Wagner <dwagner@suse.de>
Thu, 13 Jan 2022 17:39:50 +0000 (18:39 +0100)
commit659a37c1c380310e8ca3041277dbb85196744f60
tree2c4991071059114a8fbc27be3546953b74eebbd5
parentb5b991d4082654df97315b951622622932aa8082
ioctl: Rearrange members in nvme_get_log_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_get_log_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        enum nvme_cmd_get_log_lid  lid;                  /*    20     4 */
        __u64                      lpo;                  /*    24     8 */
        void *                     log;                  /*    32     8 */
        __u32                      len;                  /*    40     4 */
        __u32                      nsid;                 /*    44     4 */
        enum nvme_csi              csi;                  /*    48     4 */
        __u16                      lsi;                  /*    52     2 */
        __u8                       lsp;                  /*    54     1 */
        __u8                       uuidx;                /*    55     1 */
        _Bool                      rae;                  /*    56     1 */
        _Bool                      ot;                   /*    57     1 */

        /* size: 64, cachelines: 1, members: 15 */
        /* padding: 6 */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>
src/nvme/ioctl.h