]> www.infradead.org Git - users/hch/misc.git/commit
do_umount(): add missing barrier before refcount checks in sync case
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 29 Apr 2025 03:56:14 +0000 (23:56 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Fri, 9 May 2025 22:05:55 +0000 (18:05 -0400)
commit65781e19dcfcb4aed1167d87a3ffcc2a0c071d47
treebcb00291386cc4f07f1f1eaf15073b6877dea46e
parent250cf3693060a5f803c5f1ddc082bb06b16112a9
do_umount(): add missing barrier before refcount checks in sync case

do_umount() analogue of the race fixed in 119e1ef80ecf "fix
__legitimize_mnt()/mntput() race".  Here we want to make sure that
if __legitimize_mnt() doesn't notice our lock_mount_hash(), we will
notice their refcount increment.  Harder to hit than mntput_no_expire()
one, fortunately, and consequences are milder (sync umount acting
like umount -l on a rare race with RCU pathwalk hitting at just the
wrong time instead of use-after-free galore mntput_no_expire()
counterpart used to be hit).  Still a bug...

Fixes: 48a066e72d97 ("RCU'd vfsmounts")
Reviewed-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/namespace.c