]> www.infradead.org Git - users/jedix/linux-maple.git/commit
regmap: Fix possible shift overflow in regmap_field_init()
authorMaxime Coquelin <maxime.coquelin@st.com>
Tue, 16 Jun 2015 11:53:19 +0000 (13:53 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 21 Jul 2015 17:10:04 +0000 (10:10 -0700)
commit6489f7a496378983980e8219dfaeaf66d581590b
treecd31af24f8bd9ba0c916d85e10c889b3720c6457
parent88822cdb258714ce2fdc9a6eed87e7dd7d205a6b
regmap: Fix possible shift overflow in regmap_field_init()

commit 921cc29473a0d7c109105c1876ddb432f4a4be7d upstream.

The way the mask is generated in regmap_field_init() is wrong.
Indeed, a field initialized with msb = 31 and lsb = 0 provokes a shift
overflow while calculating the mask field.

On some 32 bits architectures, such as x86, the generated mask is 0,
instead of the expected 0xffffffff.

This patch uses GENMASK() to fix the problem, as this macro is already safe
regarding shift overflow.

Signed-off-by: Maxime Coquelin <maxime.coquelin@st.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/regmap/regmap.c