]> www.infradead.org Git - users/hch/misc.git/commit
nvme-multipath: system fails to create generic nvme device
authorHannes Reinecke <hare@kernel.org>
Sat, 14 Sep 2024 12:01:22 +0000 (14:01 +0200)
committerKeith Busch <kbusch@kernel.org>
Wed, 25 Sep 2024 06:30:28 +0000 (23:30 -0700)
commit63bcf9014e95a7d279d10d8e2caa5d88db2b1855
treead3120c68487ff0975e7dacb25717a26616b56f9
parent65f666c6203600053478ce8e34a1db269a8701c9
nvme-multipath: system fails to create generic nvme device

NVME_NSHEAD_DISK_LIVE is a flag for struct nvme_ns_head, not nvme_ns.
The current code has a typo causing NVME_NSHEAD_DISK_LIVE never to
be cleared once device_add_disk_fails, causing the system never to
create the 'generic' character device. Even several rescan attempts
will change the situation and the system has to be rebooted to fix
the issue.

Fixes: 11384580e332 ("nvme-multipath: add error handling support for add_disk()")
Signed-off-by: Hannes Reinecke <hare@kernel.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/multipath.c