]> www.infradead.org Git - users/dwmw2/linux.git/commit
netem: Update sch->q.qlen before qdisc_tree_reduce_backlog()
authorCong Wang <cong.wang@bytedance.com>
Tue, 4 Feb 2025 00:58:40 +0000 (16:58 -0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 6 Feb 2025 02:14:46 +0000 (18:14 -0800)
commit638ba5089324796c2ee49af10427459c2de35f71
tree1a044609bfa587a2a36d1010a0fe41eb0aa91d26
parent3fe5648d1df1798ce14b5464b2ea49f10cd9db31
netem: Update sch->q.qlen before qdisc_tree_reduce_backlog()

qdisc_tree_reduce_backlog() notifies parent qdisc only if child
qdisc becomes empty, therefore we need to reduce the backlog of the
child qdisc before calling it. Otherwise it would miss the opportunity
to call cops->qlen_notify(), in the case of DRR, it resulted in UAF
since DRR uses ->qlen_notify() to maintain its active list.

Fixes: f8d4bc455047 ("net/sched: netem: account for backlog updates from child qdisc")
Cc: Martin Ottens <martin.ottens@fau.de>
Reported-by: Mingi Cho <mincho@theori.io>
Signed-off-by: Cong Wang <cong.wang@bytedance.com>
Link: https://patch.msgid.link/20250204005841.223511-4-xiyou.wangcong@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sched/sch_netem.c