]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ALSA: pcm : Call kill_fasync() in stream lock
authorTakashi Iwai <tiwai@suse.de>
Mon, 5 Dec 2016 19:16:37 +0000 (11:16 -0800)
committerDhaval Giani <dhaval.giani@oracle.com>
Mon, 16 Jan 2017 21:43:36 +0000 (16:43 -0500)
commit6351915b5acda403e63badcc48a3683bd9b3aa4c
tree5397fcd2fc0c787355d67d3945d057723d4a34be
parentf406e133bed5b0a7fae05ff0188824315eae5ba1
ALSA: pcm : Call kill_fasync() in stream lock

Currently kill_fasync() is called outside the stream lock in
snd_pcm_period_elapsed().  This is potentially racy, since the stream
may get released even during the irq handler is running.  Although
snd_pcm_release_substream() calls snd_pcm_drop(), this doesn't
guarantee that the irq handler finishes, thus the kill_fasync() call
outside the stream spin lock may be invoked after the substream is
detached, as recently reported by KASAN.

As a quick workaround, move kill_fasync() call inside the stream
lock.  The fasync is rarely used interface, so this shouldn't have a
big impact from the performance POV.

Ideally, we should implement some sync mechanism for the proper finish
of stream and irq handler.  But this oneliner should suffice for most
cases, so far.

Reported-by: Baozeng Ding <sploving1@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
(cherry picked from commit 3aa02cb664c5fb1042958c8d1aa8c35055a2ebc4)

Conflicts:

sound/core/pcm_lib.c

Orabug: 25203165
CVE: CVE-2016-9794
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
Reviewed-by: Jack Vogel <jack.vogel@oracle.com>
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
sound/core/pcm_lib.c