]> www.infradead.org Git - users/jedix/linux-maple.git/commit
x86/mm: Check return value from memblock_phys_alloc_range()
authorPhilip Redkin <me@rarity.fan>
Fri, 15 Nov 2024 17:36:59 +0000 (20:36 +0300)
committerIngo Molnar <mingo@kernel.org>
Wed, 19 Mar 2025 10:05:22 +0000 (11:05 +0100)
commit631ca8909fd5c62b9fda9edda93924311a78a9c4
tree3596cad1cb9804115549470b70024081b4924f32
parent89771319e0f11314fcf6d22fcdd0c41e2d157ddc
x86/mm: Check return value from memblock_phys_alloc_range()

At least with CONFIG_PHYSICAL_START=0x100000, if there is < 4 MiB of
contiguous free memory available at this point, the kernel will crash
and burn because memblock_phys_alloc_range() returns 0 on failure,
which leads memblock_phys_free() to throw the first 4 MiB of physical
memory to the wolves.

At a minimum it should fail gracefully with a meaningful diagnostic,
but in fact everything seems to work fine without the weird reserve
allocation.

Signed-off-by: Philip Redkin <me@rarity.fan>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Rik van Riel <riel@surriel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Link: https://lore.kernel.org/r/94b3e98f-96a7-3560-1f76-349eb95ccf7f@rarity.fan
arch/x86/mm/init.c