]> www.infradead.org Git - users/jedix/linux-maple.git/commit
media: pci: ivtv: Add check for DMA map result
authorMikhail Kobuk <m.kobuk@ispras.ru>
Wed, 27 Mar 2024 23:32:23 +0000 (02:32 +0300)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Fri, 31 May 2024 11:51:15 +0000 (13:51 +0200)
commit629913d6d79508b166c66e07e4857e20233d85a9
tree88b2287c01558b7e65e5dae5c78711000529e7b8
parentdd40472dc6d7078746680e71ed2f4cc9c4e15b0a
media: pci: ivtv: Add check for DMA map result

In case DMA fails, 'dma->SG_length' is 0. This value is later used to
access 'dma->SGarray[dma->SG_length - 1]', which will cause out of
bounds access.

Add check to return early on invalid value. Adjust warnings accordingly.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 1932dc2f4cf6 ("media: pci/ivtv: switch from 'pci_' to 'dma_' API")
Signed-off-by: Mikhail Kobuk <m.kobuk@ispras.ru>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/pci/ivtv/ivtv-udma.c
drivers/media/pci/ivtv/ivtv-yuv.c
drivers/media/pci/ivtv/ivtvfb.c