]> www.infradead.org Git - users/jedix/linux-maple.git/commit
USB: gadget: f_hid: Fix memory leak in hidg_bind error path
authorYuhao Jiang <danisjiang@gmail.com>
Mon, 23 Jun 2025 09:48:44 +0000 (17:48 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 Jul 2025 09:03:33 +0000 (11:03 +0200)
commit62783c30d78aecf9810dae46fd4d11420ad38b74
treeae96d5beefa507b8dd3e3f1376e4af9b9549e9d3
parent81c3b7256f9ec3c9f7659e4a2aec8d8ead0d4c3b
USB: gadget: f_hid: Fix memory leak in hidg_bind error path

In hidg_bind(), if alloc_workqueue() fails after usb_assign_descriptors()
has successfully allocated the USB descriptors, the current error handling
does not call usb_free_all_descriptors() to free the allocated descriptors,
resulting in a memory leak.

Restructure the error handling by adding proper cleanup labels:
- fail_free_all: cleans up workqueue and descriptors
- fail_free_descs: cleans up descriptors only
- fail: original cleanup for earlier failures

This ensures that allocated resources are properly freed in reverse order
of their allocation, preventing the memory leak when alloc_workqueue() fails.

Fixes: a139c98f760ef ("USB: gadget: f_hid: Add GET_REPORT via userspace IOCTL")
Cc: stable@vger.kernel.org
Signed-off-by: Yuhao Jiang <danisjiang@gmail.com>
Link: https://lore.kernel.org/r/20250623094844.244977-1-danisjiang@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/function/f_hid.c