]> www.infradead.org Git - users/willy/pagecache.git/commit
ixgbe: Fix possible skb NULL pointer dereference
authorPiotr Kwapulinski <piotr.kwapulinski@intel.com>
Fri, 31 Jan 2025 12:14:50 +0000 (13:14 +0100)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 11 Feb 2025 17:13:11 +0000 (09:13 -0800)
commit61fb097f9a644407b9342a8169d0edef868612d7
tree64bd5b0ae91abbdc603dd5ef52e4f2ddceb08700
parent52c11d31b5a1d1c747bb5f36cc4808e93e2348f4
ixgbe: Fix possible skb NULL pointer dereference

The commit c824125cbb18 ("ixgbe: Fix passing 0 to ERR_PTR in
ixgbe_run_xdp()") stopped utilizing the ERR-like macros for xdp status
encoding. Propagate this logic to the ixgbe_put_rx_buffer().

The commit also relaxed the skb NULL pointer check - caught by Smatch.
Restore this check.

Fixes: c824125cbb18 ("ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/intel-wired-lan/2c7d6c31-192a-4047-bd90-9566d0e14cc0@stanley.mountain/
Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: Piotr Kwapulinski <piotr.kwapulinski@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Saritha Sanigani <sarithax.sanigani@intel.com> (A Contingent Worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c