]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net: usb: asix: ax88772: Increase phy_name size
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 24 Mar 2025 14:39:30 +0000 (16:39 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 25 Mar 2025 21:35:32 +0000 (14:35 -0700)
commit61997271a5a7dcd5a7dd5f0d81e4cb045e1db9ef
tree7a4f6f5861ea19862846e77f45add5f18ed46623
parent2c5ac026fd1421cf6a78770b48570b2563ef40b7
net: usb: asix: ax88772: Increase phy_name size

GCC compiler (Debian 14.2.0-17) is not happy about printing
into a too short buffer (when build with `make W=1`):

 drivers/net/usb/ax88172a.c:311:9: note: ‘snprintf’ output between 4 and 66 bytes into a destination of size 20

Indeed, the buffer size is chosen based on some assumptions,
while in general the assigned name might not fit. Increase
the buffer size to cover the minimum required one. With that,
change snprintf() to use sizeof() instead of the hard coded
value.

While at it, make sure that the PHY address is not bigger than
the allowed maximum.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20250324144751.1271761-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/usb/ax88172a.c