]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net: tulip: avoid unused variable warning
authorSimon Horman <horms@kernel.org>
Tue, 18 Mar 2025 13:53:34 +0000 (13:53 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 25 Mar 2025 11:32:39 +0000 (04:32 -0700)
commit6165feda3d8cd42663e50aa090e341e673990950
tree9554f866fc22c05bec4a0af620f2f98e74d05fcd
parent5555b34c581d943e3c837cc4fd75cc3b563f4726
net: tulip: avoid unused variable warning

There is an effort to achieve W=1 kernel builds without warnings.
As part of that effort Helge Deller highlighted the following warnings
in the tulip driver when compiling with W=1 and CONFIG_TULIP_MWI=n:

  .../tulip_core.c: In function ‘tulip_init_one’:
  .../tulip_core.c:1309:22: warning: variable ‘force_csr0’ set but not used

This patch addresses that problem using IS_ENABLED(). This approach has
the added benefit of reducing conditionally compiled code. And thus
increasing compile coverage. E.g. for allmodconfig builds which enable
CONFIG_TULIP_MWI.

Compile tested only.
No run-time effect intended.

Acked-by: Helge Deller <deller@gmx.de>
Signed-off-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250318-tulip-w1-v3-1-a813fadd164d@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/dec/tulip/tulip_core.c