]> www.infradead.org Git - users/jedix/linux-maple.git/commit
watchdog/perf: optimize bytes copied and remove manual NUL-termination
authorThorsten Blum <thorsten.blum@linux.dev>
Thu, 13 Mar 2025 13:30:02 +0000 (14:30 +0100)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 17 Mar 2025 19:17:01 +0000 (12:17 -0700)
commit6164be01f1799458b5c6f59a547d6241e4a4b4d6
tree82517046ea8d1a5f8c51bfaf95e1fc81e8867a28
parentceb08ee965a20dd1eecc4cdcaa0328fc7c03b1e5
watchdog/perf: optimize bytes copied and remove manual NUL-termination

Currently, up to 23 bytes of the source string are copied to the
destination buffer (including the comma and anything after it), only to
then manually NUL-terminate the destination buffer again at index 'len'
(where the comma was found).

Fix this by calling strscpy() with 'len' instead of the destination buffer
size to copy only as many bytes from the source string as needed.

Change the length check to allow 'len' to be less than or equal to the
destination buffer size to fill the whole buffer if needed.

Remove the if-check for the return value of strscpy(), because calling
strscpy() with 'len' always truncates the source string at the comma as
expected and NUL-terminates the destination buffer at the corresponding
index instead.  Remove the manual NUL-termination.

No functional changes intended.

Link: https://lkml.kernel.org/r/20250313133004.36406-2-thorsten.blum@linux.dev
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Song Liu <song@kernel.org>
Cc: Thomas Gleinxer <tglx@linutronix.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
kernel/watchdog_perf.c