]> www.infradead.org Git - users/hch/misc.git/commit
md/md-bitmap: fix wrong bitmap_limit for clustermd when write sb
authorSu Yue <glass.su@suse.com>
Mon, 3 Mar 2025 03:39:18 +0000 (11:39 +0800)
committerYu Kuai <yukuai@kernel.org>
Tue, 4 Mar 2025 16:34:00 +0000 (00:34 +0800)
commit6130825f34d41718c98a9b1504a79a23e379701e
treeb038d8b4bbe54fa6c2cf8333ffc561ccd53659d5
parente879a0d9cb086c8e52ce6c04e5bfa63825a6213c
md/md-bitmap: fix wrong bitmap_limit for clustermd when write sb

In clustermd, separate write-intent-bitmaps are used for each cluster
node:

0                    4k                     8k                    12k
-------------------------------------------------------------------
| idle                | md super            | bm super [0] + bits |
| bm bits[0, contd]   | bm super[1] + bits  | bm bits[1, contd]   |
| bm super[2] + bits  | bm bits [2, contd]  | bm super[3] + bits  |
| bm bits [3, contd]  |                     |                     |

So in node 1, pg_index in __write_sb_page() could equal to
bitmap->storage.file_pages. Then bitmap_limit will be calculated to
0. md_super_write() will be called with 0 size.
That means the first 4k sb area of node 1 will never be updated
through filemap_write_page().
This bug causes hang of mdadm/clustermd_tests/01r1_Grow_resize.

Here use (pg_index % bitmap->storage.file_pages) to make calculation
of bitmap_limit correct.

Fixes: ab99a87542f1 ("md/md-bitmap: fix writing non bitmap pages")
Signed-off-by: Su Yue <glass.su@suse.com>
Reviewed-by: Heming Zhao <heming.zhao@suse.com>
Link: https://lore.kernel.org/linux-raid/20250303033918.32136-1-glass.su@suse.com
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
drivers/md/md-bitmap.c