]> www.infradead.org Git - users/dwmw2/linux.git/commit
xen: privcmd: Fix possible access to a freed kirqfd instance
authorViresh Kumar <viresh.kumar@linaro.org>
Tue, 18 Jun 2024 09:42:29 +0000 (15:12 +0530)
committerJuergen Gross <jgross@suse.com>
Tue, 2 Jul 2024 10:23:42 +0000 (12:23 +0200)
commit611ff1b1ae989a7bcce3e2a8e132ee30e968c557
tree684af3e201002c451f9ddabfa63fbffd53f1bd0d
parent1c682593096a487fd9aebc079a307ff7a6d054a3
xen: privcmd: Fix possible access to a freed kirqfd instance

Nothing prevents simultaneous ioctl calls to privcmd_irqfd_assign() and
privcmd_irqfd_deassign(). If that happens, it is possible that a kirqfd
created and added to the irqfds_list by privcmd_irqfd_assign() may get
removed by another thread executing privcmd_irqfd_deassign(), while the
former is still using it after dropping the locks.

This can lead to a situation where an already freed kirqfd instance may
be accessed and cause kernel oops.

Use SRCU locking to prevent the same, as is done for the KVM
implementation for irqfds.

Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Juergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/9e884af1f1f842eacbb7afc5672c8feb4dea7f3f.1718703669.git.viresh.kumar@linaro.org
Signed-off-by: Juergen Gross <jgross@suse.com>
drivers/xen/privcmd.c