]> www.infradead.org Git - users/hch/configfs.git/commit
iommu: Do not return 0 from map_pages if it doesn't do anything
authorJason Gunthorpe <jgg@nvidia.com>
Thu, 22 Aug 2024 14:45:55 +0000 (11:45 -0300)
committerJoerg Roedel <jroedel@suse.de>
Mon, 26 Aug 2024 07:16:13 +0000 (09:16 +0200)
commit6093cd582f8e027117a8d4ad5d129a1aacdc53d2
tree0c8881c408e46f556f6c9dca62c60a3051989039
parent996dc53ac289b81957aa70d62ccadc6986d26a87
iommu: Do not return 0 from map_pages if it doesn't do anything

These three implementations of map_pages() all succeed if a mapping is
requested with no read or write. Since they return back to __iommu_map()
leaving the mapped output as 0 it triggers an infinite loop. Therefore
nothing is using no-access protection bits.

Further, VFIO and iommufd rely on iommu_iova_to_phys() to get back PFNs
stored by map, if iommu_map() succeeds but iommu_iova_to_phys() fails that
will create serious bugs.

Thus remove this never used "nothing to do" concept and just fail map
immediately.

Fixes: e5fc9753b1a8 ("iommu/io-pgtable: Add ARMv7 short descriptor support")
Fixes: e1d3c0fd701d ("iommu: add ARM LPAE page table allocator")
Fixes: 745ef1092bcf ("iommu/io-pgtable: Move Apple DART support to its own file")
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Will Deacon <will@kernel.org>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Link: https://lore.kernel.org/r/2-v1-1211e1294c27+4b1-iommu_no_prot_jgg@nvidia.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/io-pgtable-arm-v7s.c
drivers/iommu/io-pgtable-arm.c
drivers/iommu/io-pgtable-dart.c