]> www.infradead.org Git - users/jedix/linux-maple.git/commit
usb: musb: da8xx: Remove try_idle implementation from host-only mode
authorBastien Curutchet <bastien.curutchet@bootlin.com>
Tue, 28 May 2024 10:20:25 +0000 (12:20 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 4 Jun 2024 13:44:11 +0000 (15:44 +0200)
commit608662dd6081f6d3149ecd250b1054d3eb2b7d2d
tree540e6493bc820a20ffa415d653082e93f5dc0bdd
parent6ecd7749c9a2930917d43935e14b7f33e54691a7
usb: musb: da8xx: Remove try_idle implementation from host-only mode

The idle_state is not meant for host-only mode. When the device acts as a
host, it fails to exit the idle state once entered. This prevents new
USB gadgets from being detected once plugged in.

Commit 032ec49f5351 ("usb: musb: drop useless board_mode usage") removed
a is_otg_enabled() check in the try_idle() that prevented from entering
idle_state. This was removed because at that time it was not possible to
select host-only mode with CONFIG_USB_MUSB_HOST so dual role was always
set.

Add #ifndef CONFIG_USB_MUSB_HOST around try_idle() callback to prevent
from entering idle_state when host-only mode has been selected.

Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
Link: https://lore.kernel.org/r/20240528102026.40136-4-bastien.curutchet@bootlin.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/musb/da8xx.c