]> www.infradead.org Git - users/willy/pagecache.git/commit
sctp: Fix undefined behavior in left shift operation
authorYu-Chun Lin <eleanor15x@gmail.com>
Tue, 18 Feb 2025 08:12:16 +0000 (16:12 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 20 Feb 2025 02:55:40 +0000 (18:55 -0800)
commit606572eb22c1786a3957d24307f5760bb058ca19
treec61110f96d6b6dfb859ee15107392b9ae8807664
parent5bcd3d15ca13671fa7e221be38c8aed725630602
sctp: Fix undefined behavior in left shift operation

According to the C11 standard (ISO/IEC 9899:2011, 6.5.7):
"If E1 has a signed type and E1 x 2^E2 is not representable in the result
type, the behavior is undefined."

Shifting 1 << 31 causes signed integer overflow, which leads to undefined
behavior.

Fix this by explicitly using '1U << 31' to ensure the shift operates on
an unsigned type, avoiding undefined behavior.

Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>
Link: https://patch.msgid.link/20250218081217.3468369-1-eleanor15x@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sctp/stream.c