]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ALSA: pcm: Drop superfluous NULL check in snd_pcm_format_set_silence()
authorTakashi Iwai <tiwai@suse.de>
Thu, 27 Feb 2025 09:51:49 +0000 (10:51 +0100)
committerTakashi Iwai <tiwai@suse.de>
Thu, 27 Feb 2025 11:25:54 +0000 (12:25 +0100)
commit604a0fe88db0ecef56ac38156a154945f4535ddf
treefc79fecf869a3c55817089cedb2f59d180d79070
parent0f1f26c59196c785ced9f1a083ff350a6361c39f
ALSA: pcm: Drop superfluous NULL check in snd_pcm_format_set_silence()

We applied a fix for a KASAN issue for snd_pcm_format_set_silence(),
and it introduced a NULL check of pat.  But this turned out to be
utterly superfluous; it points to pcm_formats[].silence, and this is
an array, which can be never NULL.

The problem (supposedly) it tried to address at that time was likely
already fixed by another commit 8423f0b6d513 ("ALSA: pcm: oss: Fix
race at SNDCTL_DSP_SYNC") instead.

So let's drop the superfluous NULL check again.  While we're at it,
keep the whitespace fix and move the pat assignment after the width
check for a bit better code readability.

Fixes: 2f7a26abb824 ("ALSA: pcm: Test for "silence" field in struct "pcm_format_data"")
Link: https://patch.msgid.link/20250227095150.8187-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/pcm_misc.c