]> www.infradead.org Git - users/willy/pagecache.git/commit
nfsd: fix uninitialised slot info when a request is retried
authorNeilBrown <neilb@suse.de>
Mon, 27 Jan 2025 23:05:03 +0000 (10:05 +1100)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 10 Feb 2025 18:30:55 +0000 (13:30 -0500)
commit5fb25161217370eeee86b63e47060870b67ed2b4
tree69c2c533c0e2789c7f2aef9b4f0c92bac9adce42
parentb9382e29ca538b879645899ce45d652a304e2ed2
nfsd: fix uninitialised slot info when a request is retried

A recent patch moved the assignment of seq->maxslots from before the
test for a resent request (which ends with a goto) to after, resulting
in it not being run in that case.  This results in the server returning
bogus "high slot id" and "target high slot id" values.

The assignments to ->maxslots and ->target_maxslots need to be *after*
the out: label so that the correct values are returned in replies to
requests that are served from cache.

Fixes: 60aa6564317d ("nfsd: allocate new session-based DRC slots on demand.")
Signed-off-by: NeilBrown <neilb@suse.de>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4state.c