]> www.infradead.org Git - users/jedix/linux-maple.git/commit
genirq/msi: Fix off-by-one error in msi_domain_alloc()
authorJinjie Ruan <ruanjinjie@huawei.com>
Sat, 26 Oct 2024 06:36:39 +0000 (14:36 +0800)
committerThomas Gleixner <tglx@linutronix.de>
Sun, 27 Oct 2024 09:40:47 +0000 (10:40 +0100)
commit5f994f534120f47432092fb36f5cb0c7a80ed2bf
treed2dc9356128ccf59267c785c890a9d0e0f8f389b
parent42f7652d3eb527d03665b09edac47f85fb600924
genirq/msi: Fix off-by-one error in msi_domain_alloc()

The error path in msi_domain_alloc(), frees the already allocated MSI
interrupts in a loop, but the loop condition terminates when the index
reaches zero, which fails to free the first allocated MSI interrupt at
index zero.

Check for >= 0 so that msi[0] is freed as well.

Fixes: f3cf8bb0d6c3 ("genirq: Add generic msi irq domain support")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20241026063639.10711-1-ruanjinjie@huawei.com
kernel/irq/msi.c