]> www.infradead.org Git - users/jedix/linux-maple.git/commit
packet: fix heap info leak in PACKET_DIAG_MCLIST sock_diag interface
authorMathias Krause <minipli@googlemail.com>
Sun, 10 Apr 2016 10:52:28 +0000 (12:52 +0200)
committerDhaval Giani <dhaval.giani@oracle.com>
Fri, 20 Jan 2017 22:22:02 +0000 (17:22 -0500)
commit5ef79bb96cd69c293922c5b38022c59d18a3205e
tree090651087fb611052379f9768eba4cea8a04f3af
parent748440793de0a7a615c94ea9d3e7347b9b8d8dbd
packet: fix heap info leak in PACKET_DIAG_MCLIST sock_diag interface

Orabug: 25308076

[ Upstream commit 309cf37fe2a781279b7675d4bb7173198e532867 ]

Because we miss to wipe the remainder of i->addr[] in packet_mc_add(),
pdiag_put_mclist() leaks uninitialized heap bytes via the
PACKET_DIAG_MCLIST netlink attribute.

Fix this by explicitly memset(0)ing the remaining bytes in i->addr[].

Fixes: eea68e2f1a00 ("packet: Report socket mclist info via diag module")
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: Pavel Emelyanov <xemul@parallels.com>
Acked-by: Pavel Emelyanov <xemul@virtuozzo.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit 4b5223be98e1972e177f319159a29eb3bab2720e)
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
net/packet/af_packet.c