]> www.infradead.org Git - nvme.git/commit
drm/i915: mark requests for GuC virtual engines to avoid use-after-free
authorAndrzej Hajda <andrzej.hajda@intel.com>
Mon, 21 Aug 2023 15:30:35 +0000 (17:30 +0200)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Wed, 30 Aug 2023 15:32:48 +0000 (11:32 -0400)
commit5eefc5307c983b59344a4cb89009819f580c84fa
tree04a173a41f8db2f89166a7edd63187083149092c
parent3698a75f5a98d0a6599e2878ab25d30a82dd836a
drm/i915: mark requests for GuC virtual engines to avoid use-after-free

References to i915_requests may be trapped by userspace inside a
sync_file or dmabuf (dma-resv) and held indefinitely across different
proceses. To counter-act the memory leaks, we try to not to keep
references from the request past their completion.
On the other side on fence release we need to know if rq->engine
is valid and points to hw engine (true for non-virtual requests).
To make it possible extra bit has been added to rq->execution_mask,
for marking virtual engines.

Fixes: bcb9aa45d5a0 ("Revert "drm/i915: Hold reference to intel_context over life of i915_request"")
Signed-off-by: Chris Wilson <chris.p.wilson@linux.intel.com>
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230821153035.3903006-1-andrzej.hajda@intel.com
(cherry picked from commit 280410677af763f3871b93e794a199cfcf6fb580)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/i915/gt/intel_engine_types.h
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
drivers/gpu/drm/i915/i915_request.c