]> www.infradead.org Git - users/jedix/linux-maple.git/commit
fm10k: fix documentation of fm10k_tlv_parse_attr
authorJacob Keller <jacob.e.keller@intel.com>
Fri, 1 Apr 2016 23:17:35 +0000 (16:17 -0700)
committerChuck Anderson <chuck.anderson@oracle.com>
Sun, 26 Feb 2017 06:04:06 +0000 (22:04 -0800)
commit5ed7e1d585bdf4497a038570ff6853173709b09f
treefa543dd82125dcf2aa5df15761063b33b7df098a
parenta9d1b4d2574e2306ac219273478f23e81c65e7ee
fm10k: fix documentation of fm10k_tlv_parse_attr

fm10k_tlv_parse_attr is supposed to return FM10K_NOT_IMPLEMENTED for any
TLV who's attribute id lies outside the range of results. It does not do
this today. In addition, the documentation does not indicate that other
attributes which are not implemented for a given TLV will be silently
ignored. Fix this. Clean up the logic so that we don't rely on the fact
that FM10K_NOT_IMPLEMENTED is greater than zero, as this can easily
cause confusion.

A future extension could look into some way of reporting unknown TLVs
in order to make issues more easily discoverable. We can't just return
FM10K_NOT_IMPLEMENTED here because we don't want to drop the entire
message if it has an unknown TLV.

While here, update the copyright year.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Orabug: 25394529
(cherry picked from commit 4e160f2a59cec8f705583edfaa11ce5f3b3ef4a6)
Signed-off-by: Jack Vogel <jack.vogel@oracle.com>
drivers/net/ethernet/intel/fm10k/fm10k_tlv.c