]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ASoC: SOF: ipc4-pcm: Move out be_rate initialization from for loop in fixup
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Thu, 6 Feb 2025 09:49:14 +0000 (11:49 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 6 Feb 2025 16:28:00 +0000 (16:28 +0000)
commit5ea46b4360791345bd0bf4c7bf8fff5151374ea1
treebde5d53e48a7c519f79d0222e40be35aa993e4cf
parent3f78762d17701f0435ad958b2821dc3243ff34b3
ASoC: SOF: ipc4-pcm: Move out be_rate initialization from for loop in fixup

Instead of initializing the be_rate within the loop by checking i == 0 at
each iteration, move the be_rate reference initialization from the loop.
For BE single rate check we will have single comparison done at each
iteration compared to two in case the num_input_formats were higher than 1.

We still need to run the loop from index 0 to check for FE-BE rate match.

The patch also fixes bogus reports from gcc static analyzer thinking that
be_rate is used uninitialized later in the function (which was not true).

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://patch.msgid.link/20250206094914.21135-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/ipc4-pcm.c