]> www.infradead.org Git - users/willy/pagecache.git/commit
cpumask: limit FORCE_NR_CPUS to just the UP case
authorLinus Torvalds <torvalds@linux-foundation.org>
Tue, 18 Jun 2024 16:00:04 +0000 (09:00 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 18 Jun 2024 16:00:04 +0000 (09:00 -0700)
commit5d272dd1b3430bb31fa30042490fa081512424e4
tree16b41c0c08b08b0c655048e6eff51242becb332a
parent46d1907d1caaaaa422ae814c52065f243caa010a
cpumask: limit FORCE_NR_CPUS to just the UP case

Hardcoding the number of CPUs at compile time does improve code
generation, but if you get it wrong the result will be confusion.

We already limited this earlier to only "experts" (see commit
fe5759d5bfda "cpumask: limit visibility of FORCE_NR_CPUS"), but with
distro kernel configs often having EXPERT enabled, that turns out to not
be much of a limit.

To quote the philosophers at Disney: "Everyone can be an expert. And
when everyone's an expert, no one will be".

There's a runtime warning if you then set nr_cpus to anything but the
forced number, but apparently that can be ignored too [1] and by then
it's pretty much too late anyway.

If we had some real way to limit this to "embedded only", maybe it would
be worth it, but let's see if anybody even notices that the option is
gone.  We need to simplify kernel configuration anyway.

Link: https://lore.kernel.org/all/20240618105036.208a8860@rorschach.local.home/
Reported-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Paul McKenney <paulmck@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Yury Norov <yury.norov@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
lib/Kconfig