]> www.infradead.org Git - users/jedix/linux-maple.git/commit
APEI: GHES: Have GHES honor the panic= setting
authorBorislav Petkov <bp@alien8.de>
Mon, 13 Jan 2025 12:52:24 +0000 (13:52 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 14 Jan 2025 17:27:55 +0000 (18:27 +0100)
commit5c0e00a391dd0099fe95991bb2f962848d851916
treeb39ea82d141abcf66b0d6770e71696f5057f3fb4
parent5bc55a333a2f7316b58edc7573e8e893f7acb532
APEI: GHES: Have GHES honor the panic= setting

The GHES driver overrides the panic= setting by force-rebooting the
system after a fatal hw error has been reported. The intent being that
such an error would be reported earlier.

However, this is not optimal when a hard-to-debug issue requires long
time to reproduce and when that happens, the box will get rebooted after
30 seconds and thus destroy the whole hw context of when the error
happened.

So rip out the default GHES panic timeout and honor the global one.

In the panic disabled (panic=0) case, the error will still be logged to
dmesg for later inspection and if panic after a hw error is really
required, then that can be controlled the usual way - use panic= on the
cmdline or set it in the kernel .config's CONFIG_PANIC_TIMEOUT.

Reported-by: Feng Tang <feng.tang@linux.alibaba.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Feng Tang <feng.tang@linux.alibaba.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Link: https://patch.msgid.link/20250113125224.GFZ4UMiNtWIJvgpveU@fat_crate.local
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/apei/ghes.c