]> www.infradead.org Git - users/hch/misc.git/commit
sch_htb: make htb_qlen_notify() idempotent
authorCong Wang <xiyou.wangcong@gmail.com>
Thu, 3 Apr 2025 21:10:23 +0000 (14:10 -0700)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 8 Apr 2025 08:57:49 +0000 (10:57 +0200)
commit5ba8b837b522d7051ef81bacf3d95383ff8edce5
tree75996ee2ece3aab43a008419ff7a56fa7bc5fbb5
parent69ae94725f4fc9e75219d2d69022029c5b24bc9a
sch_htb: make htb_qlen_notify() idempotent

htb_qlen_notify() always deactivates the HTB class and in fact could
trigger a warning if it is already deactivated. Therefore, it is not
idempotent and not friendly to its callers, like fq_codel_dequeue().

Let's make it idempotent to ease qdisc_tree_reduce_backlog() callers'
life.

Reported-by: Gerrard Tai <gerrard.tai@starlabs.sg>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250403211033.166059-2-xiyou.wangcong@gmail.com
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/sched/sch_htb.c