]> www.infradead.org Git - users/jedix/linux-maple.git/commit
clocksource/drivers/imx-tpm: Fix return -ETIME when delta exceeds INT_MAX
authorJacky Bai <ping.bai@nxp.com>
Thu, 25 Jul 2024 19:33:54 +0000 (15:33 -0400)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Mon, 2 Sep 2024 08:04:15 +0000 (10:04 +0200)
commit5b8843fcd49827813da80c0f590a17ae4ce93c5d
tree28b204650c6f4e62394993d294f38a58006a1ad0
parent471ef0b5a8aaca4296108e756b970acfc499ede4
clocksource/drivers/imx-tpm: Fix return -ETIME when delta exceeds INT_MAX

In tpm_set_next_event(delta), return -ETIME by wrong cast to int when delta
is larger than INT_MAX.

For example:

tpm_set_next_event(delta = 0xffff_fffe)
{
        ...
        next = tpm_read_counter(); // assume next is 0x10
        next += delta; // next will 0xffff_fffe + 0x10 = 0x1_0000_000e
        now = tpm_read_counter();  // now is 0x10
        ...

        return (int)(next - now) <= 0 ? -ETIME : 0;
                     ^^^^^^^^^^
                     0x1_0000_000e - 0x10 = 0xffff_fffe, which is -2 when
                     cast to int. So return -ETIME.
}

To fix this, introduce a 'prev' variable and check if 'now - prev' is
larger than delta.

Cc: stable@vger.kernel.org
Fixes: 059ab7b82eec ("clocksource/drivers/imx-tpm: Add imx tpm timer support")
Signed-off-by: Jacky Bai <ping.bai@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Jason Liu <jason.hui.liu@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20240725193355.1436005-1-Frank.Li@nxp.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
drivers/clocksource/timer-imx-tpm.c