]> www.infradead.org Git - users/dwmw2/linux.git/commit
MIPS: Alchemy: Use kcalloc() instead of kzalloc()
authorErick Archer <erick.archer@gmx.com>
Sat, 20 Jan 2024 13:34:43 +0000 (14:34 +0100)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Tue, 20 Feb 2024 12:36:34 +0000 (13:36 +0100)
commit5b7236c198a30d736a7664e26b09b5e3e8a914f4
tree060e1bed275d836afe2211e756430f24cd0f8f2c
parente34813c2dac8cece48e4f8781f38479847e4e951
MIPS: Alchemy: Use kcalloc() instead of kzalloc()

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the purpose specific kcalloc() function instead of the argument
size * count in the kzalloc() function.

Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
Link: https://github.com/KSPP/linux/issues/162
Signed-off-by: Erick Archer <erick.archer@gmx.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
arch/mips/alchemy/common/clock.c