]> www.infradead.org Git - users/jedix/linux-maple.git/commit
target: Fix target_release_cmd_kref shutdown comp leak
authorHimanshu Madhani <himanshu.madhani@qlogic.com>
Tue, 15 Mar 2016 05:47:37 +0000 (22:47 -0700)
committerChuck Anderson <chuck.anderson@oracle.com>
Thu, 26 May 2016 22:46:37 +0000 (15:46 -0700)
commit5a570614ce0c83fce40d508e861de1ad3dd046a3
tree3ea0c887479dcf7b3527fb4499b6d0441db4b460
parent66d342acf86f5f8fab0250ac6c3fcdf44a2f931b
target: Fix target_release_cmd_kref shutdown comp leak

Orabug: 23331148

[ Upstream commit 5e47f1985d7107331c3f64fb3ec83d66fd73577e ]

This patch fixes an active I/O shutdown bug for fabric
drivers using target_wait_for_sess_cmds(), where se_cmd
descriptor shutdown would result in hung tasks waiting
indefinitely for se_cmd->cmd_wait_comp to complete().

To address this bug, drop the incorrect list_del_init()
usage in target_wait_for_sess_cmds() and always complete()
during se_cmd target_release_cmd_kref() put, in order to
let caller invoke the final fabric release callback
into se_cmd->se_tfo->release_cmd() code.

Reported-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Tested-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Dan Duval <dan.duval@oracle.com>
(cherry picked from commit b90311472f0dc0aa7a7223c1220db47ce4db5447)

Conflict:

drivers/target/target_core_transport.c
drivers/target/target_core_transport.c